diff options
| author |   Chen Zhongjin <chenzhongjin@huawei.com> | 2022-11-01 19:52:52 +0800 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2022-11-02 10:47:22 +0100 |
| commit | cbc1dd5b659f5a2c3cba88b197b7443679bb35a0 (patch) | |
| tree | 32c6921e0fd126b74b3479e85b90e461d8f99675 /tools/scripts/ssh:/git@git.zx2c4.com | |
| parent | ipvs: fix WARNING in ip_vs_app_net_cleanup() (diff) | |
| download | linux-dev-cbc1dd5b659f5a2c3cba88b197b7443679bb35a0.tar.xz linux-dev-cbc1dd5b659f5a2c3cba88b197b7443679bb35a0.zip | |
netfilter: nf_nat: Fix possible memory leak in nf_nat_init()
In nf_nat_init(), register_nf_nat_bpf() can fail and return directly
without any error handling.
Then nf_nat_bysource will leak and registering of &nat_net_ops,
&follow_master_nat and nf_nat_hook won't be reverted.
This leaves wild ops in linkedlists and when another module tries to
call register_pernet_operations() or nf_ct_helper_expectfn_register()
it triggers page fault:
BUG: unable to handle page fault for address: fffffbfff81b964c
RIP: 0010:register_pernet_operations+0x1b9/0x5f0
Call Trace:
<TASK>
register_pernet_subsys+0x29/0x40
ebtables_init+0x58/0x1000 [ebtables]
...
Fixes: 820dc0523e05 ("net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'tools/scripts/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions