diff options
| author |   Matthew Wilcox <mawilcox@microsoft.com> | 2017-03-03 12:16:10 -0500 |
|---|---|---|
| committer | Matthew Wilcox <mawilcox@microsoft.com> | 2017-03-07 13:18:23 -0500 |
| commit | 4ecd9542dbc3e07f3bd3870aac12839f72b47db4 (patch) | |
| tree | 1345c7ca57563006a0355bec1bbe689dd14ca67c /tools/testing/radix-tree/test.h | |
| parent | radix tree test suite: Depend on Makefile and quieten grep (diff) | |
| download | linux-dev-4ecd9542dbc3e07f3bd3870aac12839f72b47db4.tar.xz linux-dev-4ecd9542dbc3e07f3bd3870aac12839f72b47db4.zip | |
ida: Free correct IDA bitmap
There's a relatively rare race where we look at the per-cpu preallocated
IDA bitmap, see it's NULL, allocate a new one, and atomically update it.
If the kmalloc() happened to sleep and we were rescheduled to a different
CPU, or an interrupt came in at the exact right time, another task
might have successfully allocated a bitmap and already deposited it.
I forgot what the semantics of cmpxchg() were and ended up freeing the
wrong bitmap leading to KASAN reporting a use-after-free.
Dmitry found the bug with syzkaller & wrote the patch. I wrote the test
case that will reproduce the bug without his patch being applied.
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
Diffstat (limited to 'tools/testing/radix-tree/test.h')
| -rw-r--r-- | tools/testing/radix-tree/test.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/testing/radix-tree/test.h b/tools/testing/radix-tree/test.h index b30e11d9d271..0f8220cc6166 100644 --- a/tools/testing/radix-tree/test.h +++ b/tools/testing/radix-tree/test.h @@ -36,6 +36,7 @@ void iteration_test(unsigned order, unsigned duration); void benchmark(void); void idr_checks(void); void ida_checks(void); +void ida_thread_tests(void); struct item * item_tag_set(struct radix_tree_root *root, unsigned long index, int tag); |