aboutsummaryrefslogtreecommitdiffstats
path: root/tools/testing/selftests/bpf/progs/test_d_path.c
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@kernel.org>2020-09-18 13:23:38 +0200
committerAlexei Starovoitov <ast@kernel.org>2020-09-21 16:18:00 -0700
commita8a717963fe5ecfd274eb93dd1285ee9428ffca7 (patch)
tree62c0f3340551492668d4416a74cd26ba07242258 /tools/testing/selftests/bpf/progs/test_d_path.c
parentbpf: Using rcu_read_lock for bpf_sk_storage_map iterator (diff)
downloadlinux-dev-a8a717963fe5ecfd274eb93dd1285ee9428ffca7.tar.xz
linux-dev-a8a717963fe5ecfd274eb93dd1285ee9428ffca7.zip
selftests/bpf: Fix stat probe in d_path test
Some kernels builds might inline vfs_getattr call within fstat syscall code path, so fentry/vfs_getattr trampoline is not called. Add security_inode_getattr to allowlist and switch the d_path test stat trampoline to security_inode_getattr. Keeping dentry_open and filp_close, because they are in their own files, so unlikely to be inlined, but in case they are, adding security_file_open. Adding flags that indicate trampolines were called and failing the test if any of them got missed, so it's easier to identify the issue next time. Fixes: e4d1af4b16f8 ("selftests/bpf: Add test for d_path helper") Suggested-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Jiri Olsa <jolsa@redhat.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Link: https://lore.kernel.org/bpf/20200918112338.2618444-1-jolsa@kernel.org
Diffstat (limited to 'tools/testing/selftests/bpf/progs/test_d_path.c')
-rw-r--r--tools/testing/selftests/bpf/progs/test_d_path.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/progs/test_d_path.c b/tools/testing/selftests/bpf/progs/test_d_path.c
index 61f007855649..84e1f883f97b 100644
--- a/tools/testing/selftests/bpf/progs/test_d_path.c
+++ b/tools/testing/selftests/bpf/progs/test_d_path.c
@@ -15,7 +15,10 @@ char paths_close[MAX_FILES][MAX_PATH_LEN] = {};
int rets_stat[MAX_FILES] = {};
int rets_close[MAX_FILES] = {};
-SEC("fentry/vfs_getattr")
+int called_stat = 0;
+int called_close = 0;
+
+SEC("fentry/security_inode_getattr")
int BPF_PROG(prog_stat, struct path *path, struct kstat *stat,
__u32 request_mask, unsigned int query_flags)
{
@@ -23,6 +26,8 @@ int BPF_PROG(prog_stat, struct path *path, struct kstat *stat,
__u32 cnt = cnt_stat;
int ret;
+ called_stat = 1;
+
if (pid != my_pid)
return 0;
@@ -42,6 +47,8 @@ int BPF_PROG(prog_close, struct file *file, void *id)
__u32 cnt = cnt_close;
int ret;
+ called_close = 1;
+
if (pid != my_pid)
return 0;