diff options
| author |   Daniel Borkmann <daniel@iogearbox.net> | 2017-04-27 01:39:34 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-04-28 15:48:15 -0400 |
| commit | 43bcf707ccdc79ee63edb953fcf72e6dc244cfa1 (patch) | |
| tree | 96ccafc2cde1a7eb894f04ef7b337f8d6c3201b3 /tools/testing/selftests/bpf/test_maps.c | |
| parent | bpf: bpf_lock on kallsysms doesn't need to be irqsave (diff) | |
| download | linux-dev-43bcf707ccdc79ee63edb953fcf72e6dc244cfa1.tar.xz linux-dev-43bcf707ccdc79ee63edb953fcf72e6dc244cfa1.zip | |
bpf: fix _htons occurences in test_progs
Dave reported that on sparc test_progs generates buggy swapped
eth->h_proto protocol comparisons:
10: (15) if r3 == 0xdd86 goto pc+9
R0=imm2,min_value=2,max_value=2 R1=pkt(id=0,off=0,r=14) R2=pkt_end R3=inv
R4=pkt(id=0,off=14,r=14) R5=inv56 R10=fp
This is due to the unconditional ...
#define htons __builtin_bswap16
#define ntohs __builtin_bswap16
... in test_progs that causes this. Make use of asm/byteorder.h
and use __constant_htons() where possible and only perform the
bswap16 when on little endian in non-constant case.
Fixes: 6882804c916b ("selftests/bpf: add a test for overlapping packet range checks")
Fixes: 37821613626e ("selftests/bpf: add l4 load balancer test based on sched_cls")
Reported-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/bpf/test_maps.c')
0 files changed, 0 insertions, 0 deletions