diff options
author | Andrii Nakryiko <andrii@kernel.org> | 2021-01-25 22:50:18 -0800 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-01-26 17:02:00 +0100 |
commit | 86ce322d21eb032ed8fdd294d0fb095d2debb430 (patch) | |
tree | b3def3a5fdb402d7fa70c05ed80c535b9f4b7397 /tools/testing/selftests/bpf/test_progs.c | |
parent | samples/bpf: Set flag __SANE_USERSPACE_TYPES__ for MIPS to fix build warnings (diff) | |
download | linux-dev-86ce322d21eb032ed8fdd294d0fb095d2debb430.tar.xz linux-dev-86ce322d21eb032ed8fdd294d0fb095d2debb430.zip |
selftests/bpf: Don't exit on failed bpf_testmod unload
Fix bug in handling bpf_testmod unloading that will cause test_progs exiting
prematurely if bpf_testmod unloading failed. This is especially problematic
when running a subset of test_progs that doesn't require root permissions and
doesn't rely on bpf_testmod, yet will fail immediately due to exit(1) in
unload_bpf_testmod().
Fixes: 9f7fa225894c ("selftests/bpf: Add bpf_testmod kernel module for testing")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210126065019.1268027-1-andrii@kernel.org
Diffstat (limited to 'tools/testing/selftests/bpf/test_progs.c')
-rw-r--r-- | tools/testing/selftests/bpf/test_progs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c index 213628ee721c..6396932b97e2 100644 --- a/tools/testing/selftests/bpf/test_progs.c +++ b/tools/testing/selftests/bpf/test_progs.c @@ -390,7 +390,7 @@ static void unload_bpf_testmod(void) return; } fprintf(env.stderr, "Failed to unload bpf_testmod.ko from kernel: %d\n", -errno); - exit(1); + return; } if (env.verbosity > VERBOSE_NONE) fprintf(stdout, "Successfully unloaded bpf_testmod.ko.\n"); |