aboutsummaryrefslogtreecommitdiffstats
path: root/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh
diff options
context:
space:
mode:
authorPetr Machata <petrm@mellanox.com>2018-07-28 00:48:13 +0200
committerDavid S. Miller <davem@davemloft.net>2018-07-29 13:00:01 -0700
commiteef6ab8b7d3223e2ecd02a02f17523e93faba709 (patch)
tree8edd1138f473db6cb15f23de723bbaaea75ccb41 /tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh
parentMerge branch 'mtu-related-changes' (diff)
downloadlinux-dev-eef6ab8b7d3223e2ecd02a02f17523e93faba709.tar.xz
linux-dev-eef6ab8b7d3223e2ecd02a02f17523e93faba709.zip
selftests: mlxsw: qos_dscp_bridge: Fix
There are two problems in this test case: - When indexing in bash associative array, the subscript is interpreted as string, not as a variable name to be expanded. - The keys stored to t0s and t1s are not DSCP values, but priority + base (i.e. the logical DSCP value, not the full bitfield value). In combination these two bugs conspire to make the test just work, except it doesn't really test anything and always passes. Fix the above two problems in obvious manner. Signed-off-by: Petr Machata <petrm@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh')
-rwxr-xr-xtools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh
index 418319f19108..cc527660a022 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh
@@ -217,13 +217,13 @@ dscp_ping_test()
for key in ${!t0s[@]}; do
local expect
- if ((key == dscp_10 || key == dscp_20)); then
+ if ((key == prio+10 || key == prio+20)); then
expect=10
else
expect=0
fi
- local delta=$((t1s[key] - t0s[key]))
+ local delta=$((t1s[$key] - t0s[$key]))
((expect == delta))
check_err $? "DSCP $key: Expected to capture $expect packets, got $delta."
done