diff options
| author |   Petr Machata <petrm@mellanox.com> | 2018-07-08 19:58:55 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-10 22:58:10 -0700 |
| commit | db560d1612f81c932df8d31e6f3bf7581c32ba91 (patch) | |
| tree | 0adfef0d3a32b31a311f44e21852561d1b007b8a /tools/testing/selftests/net/forwarding | |
| parent | Merge branch 'cake-qdisc' (diff) | |
| download | linux-dev-db560d1612f81c932df8d31e6f3bf7581c32ba91.tar.xz linux-dev-db560d1612f81c932df8d31e6f3bf7581c32ba91.zip | |
selftests: forwarding: mirror_lib: Tighten up VLAN capture
The function do_test_span_vlan_dir_ips() is used for testing whether
mirrored packets are VLAN-encapsulated. But since it only considers
VLAN encapsulation, it may end up matching unmirrored ARP traffic as
well. One consequence is a rare failure of mirror_gre_vlan_bridge_1q's
test_gretap_untagged_egress. Decreasing ping cadence in mirror_test()
makes the problem easily reproducible.
Therefore tighten up the match criterion to only count those 802.1q
packets where the next header is IP.
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/net/forwarding')
| -rw-r--r-- | tools/testing/selftests/net/forwarding/mirror_lib.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/forwarding/mirror_lib.sh b/tools/testing/selftests/net/forwarding/mirror_lib.sh index d36dc26c6c51..07991e1025c7 100644 --- a/tools/testing/selftests/net/forwarding/mirror_lib.sh +++ b/tools/testing/selftests/net/forwarding/mirror_lib.sh @@ -105,7 +105,7 @@ do_test_span_vlan_dir_ips() # Install the capture as skip_hw to avoid double-counting of packets. # The traffic is meant for local box anyway, so will be trapped to # kernel. - vlan_capture_install $dev "skip_hw vlan_id $vid" + vlan_capture_install $dev "skip_hw vlan_id $vid vlan_ethtype ip" mirror_test v$h1 $ip1 $ip2 $dev 100 $expect mirror_test v$h2 $ip2 $ip1 $dev 100 $expect vlan_capture_uninstall $dev |