diff options
| author |   Mathieu Desnoyers <mathieu.desnoyers@efficios.com> | 2022-01-24 12:12:48 -0500 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2022-02-02 13:11:36 +0100 |
| commit | 26dc8a6d8e11552f3b797b5aafe01071ca32d692 (patch) | |
| tree | 305500a16e20756407834b7ce8bab398b4233c39 /tools/testing/selftests/rseq/rseq-x86.h | |
| parent | selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" for load/store (diff) | |
| download | linux-dev-26dc8a6d8e11552f3b797b5aafe01071ca32d692.tar.xz linux-dev-26dc8a6d8e11552f3b797b5aafe01071ca32d692.zip | |
selftests/rseq: Fix ppc32 offsets by using long rather than off_t
The semantic of off_t is for file offsets. We mean to use it as an
offset from a pointer. We really expect it to fit in a single register,
and not use a 64-bit type on 32-bit architectures.
Fix runtime issues on ppc32 where the offset is always 0 due to
inconsistency between the argument type (off_t -> 64-bit) and type
expected by the inline assembler (32-bit).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220124171253.22072-11-mathieu.desnoyers@efficios.com
Diffstat (limited to 'tools/testing/selftests/rseq/rseq-x86.h')
| -rw-r--r-- | tools/testing/selftests/rseq/rseq-x86.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/testing/selftests/rseq/rseq-x86.h b/tools/testing/selftests/rseq/rseq-x86.h index 1d9fa0516e53..0ee6c041d4be 100644 --- a/tools/testing/selftests/rseq/rseq-x86.h +++ b/tools/testing/selftests/rseq/rseq-x86.h @@ -172,7 +172,7 @@ error2: */ static inline __attribute__((always_inline)) int rseq_cmpnev_storeoffp_load(intptr_t *v, intptr_t expectnot, - off_t voffp, intptr_t *load, int cpu) + long voffp, intptr_t *load, int cpu) { RSEQ_INJECT_C(9) @@ -286,7 +286,7 @@ error1: * *pval += inc; */ static inline __attribute__((always_inline)) -int rseq_offset_deref_addv(intptr_t *ptr, off_t off, intptr_t inc, int cpu) +int rseq_offset_deref_addv(intptr_t *ptr, long off, intptr_t inc, int cpu) { RSEQ_INJECT_C(9) @@ -750,7 +750,7 @@ error2: */ static inline __attribute__((always_inline)) int rseq_cmpnev_storeoffp_load(intptr_t *v, intptr_t expectnot, - off_t voffp, intptr_t *load, int cpu) + long voffp, intptr_t *load, int cpu) { RSEQ_INJECT_C(9) |