diff options
| author |   Petr Machata <petrm@mellanox.com> | 2018-07-30 16:39:46 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-30 09:47:21 -0700 |
| commit | e094574f9bf806fb89a285c0a0263a46a1d536f9 (patch) | |
| tree | ecce00074068a93f416eab112e8b84e4a2c0975a /tools/testing | |
| parent | fib_rules: NULL check before kfree is not needed (diff) | |
| download | linux-dev-e094574f9bf806fb89a285c0a0263a46a1d536f9.tar.xz linux-dev-e094574f9bf806fb89a285c0a0263a46a1d536f9.zip | |
selftests: forwarding: lib: Add require_command()
The logic for testing whether a certain command is available is used
several times in the current code base. The tests in follow-up patches
add more requirements like that.
Therefore extract the logic into a named function, require_command(),
that can be used directly from lib.sh as well as from any test that
wishes to declare dependence on some command.
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing')
| -rw-r--r-- | tools/testing/selftests/net/forwarding/lib.sh | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index 158d59ffee40..81e36157bf16 100644 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -62,15 +62,18 @@ if [[ "$CHECK_TC" = "yes" ]]; then check_tc_version fi -if [[ ! -x "$(command -v jq)" ]]; then - echo "SKIP: jq not installed" - exit 1 -fi +require_command() +{ + local cmd=$1; shift -if [[ ! -x "$(command -v $MZ)" ]]; then - echo "SKIP: $MZ not installed" - exit 1 -fi + if [[ ! -x "$(command -v "$cmd")" ]]; then + echo "SKIP: $cmd not installed" + exit 1 + fi +} + +require_command jq +require_command $MZ if [[ ! -v NUM_NETIFS ]]; then echo "SKIP: importer does not define \"NUM_NETIFS\"" |