diff options
| author |   Halil Pasic <pasic@linux.vnet.ibm.com> | 2016-08-29 18:25:22 +0200 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2017-01-19 23:46:31 +0200 |
| commit | 21f5eda9b8671744539c8295b9df62991fffb2ce (patch) | |
| tree | 53af8d3a01968664733472f34ea6d7a999c39fe7 /tools | |
| parent | virtio_console: fix a crash in config_work_handler (diff) | |
| download | linux-dev-21f5eda9b8671744539c8295b9df62991fffb2ce.tar.xz linux-dev-21f5eda9b8671744539c8295b9df62991fffb2ce.zip | |
tools/virtio/ringtest: fix run-on-all.sh for offline cpus
Since ef1b144d ("tools/virtio/ringtest: fix run-on-all.sh to work
without /dev/cpu") run-on-all.sh uses seq 0 $HOST_AFFINITY as the list
of ids of the CPUs to run the command on (assuming ids of online CPUs
are consecutive and start from 0), where $HOST_AFFINITY is the highest
CPU id in the system previously determined using lscpu. This can fail
on systems with offline CPUs.
Instead let's use lscpu to determine the list of online CPUs.
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Fixes: ef1b144d ("tools/virtio/ringtest: fix run-on-all.sh to work without
/dev/cpu")
Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/virtio/ringtest/run-on-all.sh | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh index 2e69ca812b4c..29b0d3920bfc 100755 --- a/tools/virtio/ringtest/run-on-all.sh +++ b/tools/virtio/ringtest/run-on-all.sh @@ -1,12 +1,13 @@ #!/bin/sh +CPUS_ONLINE=$(lscpu --online -p=cpu|grep -v -e '#') #use last CPU for host. Why not the first? #many devices tend to use cpu0 by default so #it tends to be busier -HOST_AFFINITY=$(lscpu -p=cpu | tail -1) +HOST_AFFINITY=$(echo "${CPUS_ONLINE}"|tail -n 1) #run command on all cpus -for cpu in $(seq 0 $HOST_AFFINITY) +for cpu in $CPUS_ONLINE do #Don't run guest and host on same CPU #It actually works ok if using signalling |