diff options
| author |   Jiri Olsa <jolsa@redhat.com> | 2016-09-20 18:12:45 +0200 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-09-20 16:20:21 -0300 |
| commit | 3c028a0cb5b71f47d523bc8ad2c597cb257f41fb (patch) | |
| tree | 782214a4e3c7cfd92453664ebec061297452711f /tools | |
| parent | perf hists: Factor out hists__reset_column_width() (diff) | |
| download | linux-dev-3c028a0cb5b71f47d523bc8ad2c597cb257f41fb.tar.xz linux-dev-3c028a0cb5b71f47d523bc8ad2c597cb257f41fb.zip | |
perf symbols: Do not open device files
The dso__read_binary_type_filename gets the dso's file name to open. We
need to check it for regular file before trying to open it, otherwise we
might get stuck with device file.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20160920161245.GA8995@krava
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/dso.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 774f6ec884d5..d2c6cdd9d42b 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -363,6 +363,9 @@ static int __open_dso(struct dso *dso, struct machine *machine) return -EINVAL; } + if (!is_regular_file(name)) + return -EINVAL; + fd = do_open(name); free(name); return fd; |