diff options
| author |   Jinjie Ruan <ruanjinjie@huawei.com> | 2024-11-01 10:53:16 +0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2024-11-03 07:59:30 -0800 |
| commit | 3b557be89fc688dbd9ccf704a70f7600a094f13a (patch) | |
| tree | f73632c09508b487f7d0eca5c771c1ec308bfb33 | |
| parent | dt-bindings: net: xlnx,axi-ethernet: Correct phy-mode property value (diff) | |
| download | linux-rng-3b557be89fc688dbd9ccf704a70f7600a094f13a.tar.xz linux-rng-3b557be89fc688dbd9ccf704a70f7600a094f13a.zip | |
net: wwan: t7xx: Fix off-by-one error in t7xx_dpmaif_rx_buf_alloc()
The error path in t7xx_dpmaif_rx_buf_alloc(), free and unmap the already
allocated and mapped skb in a loop, but the loop condition terminates when
the index reaches zero, which fails to free the first allocated skb at
index zero.
Check with i-- so that skb at index 0 is freed as well.
Cc: stable@vger.kernel.org
Fixes: d642b012df70 ("net: wwan: t7xx: Add data path interface")
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://patch.msgid.link/20241101025316.3234023-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c index 210d84c67ef9..7a9c09cd4fdc 100644 --- a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c +++ b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c @@ -226,7 +226,7 @@ int t7xx_dpmaif_rx_buf_alloc(struct dpmaif_ctrl *dpmaif_ctrl, return 0; err_unmap_skbs: - while (--i > 0) + while (i--) t7xx_unmap_bat_skb(dpmaif_ctrl->dev, bat_req->bat_skb, i); return ret; |