diff options
| author |   Shuai Xue <xueshuai@linux.alibaba.com> | 2025-04-04 20:02:13 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2025-05-14 14:40:39 +0100 |
| commit | 61d651572b6c4fe50c7b39a390760f3a910c7ccf (patch) | |
| tree | 8fb77f0c88882e5de2933e2e2bdc0fc13e7c965a | |
| parent | dmaengine: idxd: Add missing cleanup for early error out in idxd_setup_internals (diff) | |
| download | linux-rng-61d651572b6c4fe50c7b39a390760f3a910c7ccf.tar.xz linux-rng-61d651572b6c4fe50c7b39a390760f3a910c7ccf.zip | |
dmaengine: idxd: Add missing cleanups in cleanup internals
The idxd_cleanup_internals() function only decreases the reference count
of groups, engines, and wqs but is missing the step to release memory
resources.
To fix this, use the cleanup helper to properly release the memory
resources.
Fixes: ddf742d4f3f1 ("dmaengine: idxd: Add missing cleanup for early error out in probe call")
Cc: stable@vger.kernel.org
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20250404120217.48772-6-xueshuai@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/idxd/init.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index a40fb2fd5006..f8129d2d53f1 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -407,14 +407,9 @@ static int idxd_setup_groups(struct idxd_device *idxd) static void idxd_cleanup_internals(struct idxd_device *idxd) { - int i; - - for (i = 0; i < idxd->max_groups; i++) - put_device(group_confdev(idxd->groups[i])); - for (i = 0; i < idxd->max_engines; i++) - put_device(engine_confdev(idxd->engines[i])); - for (i = 0; i < idxd->max_wqs; i++) - put_device(wq_confdev(idxd->wqs[i])); + idxd_clean_groups(idxd); + idxd_clean_engines(idxd); + idxd_clean_wqs(idxd); destroy_workqueue(idxd->wq); } |