aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2025-04-23 10:41:31 +0100
committerDavid Sterba <dsterba@suse.com>2025-05-15 14:30:52 +0200
commitb2460c2aee9a757bf0b438dde5b5ee71afc54e44 (patch)
tree1659148d847eb0669af4bd94a3ad3dfbd9017c11
parentbtrfs: avoid re-searching tree when setting bits in an extent range (diff)
downloadlinux-rng-b2460c2aee9a757bf0b438dde5b5ee71afc54e44.tar.xz
linux-rng-b2460c2aee9a757bf0b438dde5b5ee71afc54e44.zip
btrfs: remove unnecessary NULL checks before freeing extent state
When manipulating extent bits for an io tree range, we have this pattern: if (prealloc) btrfs_free_extent_state(prealloc); but this is not needed nowadays since btrfs_free_extent_state() ignores a NULL pointer argument, following the common pattern of kernel and btrfs freeing functions, as well as libc and other user space libraries. So remove the NULL checks, reducing source code and object size. Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/extent-io-tree.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/btrfs/extent-io-tree.c b/fs/btrfs/extent-io-tree.c
index dd36322fbf6b..9266bb39c619 100644
--- a/fs/btrfs/extent-io-tree.c
+++ b/fs/btrfs/extent-io-tree.c
@@ -761,8 +761,7 @@ search_again:
out:
spin_unlock(&tree->lock);
- if (prealloc)
- btrfs_free_extent_state(prealloc);
+ btrfs_free_extent_state(prealloc);
return ret;
@@ -1285,8 +1284,7 @@ search_again:
out:
spin_unlock(&tree->lock);
- if (prealloc)
- btrfs_free_extent_state(prealloc);
+ btrfs_free_extent_state(prealloc);
return ret;
@@ -1525,8 +1523,7 @@ search_again:
out:
spin_unlock(&tree->lock);
- if (prealloc)
- btrfs_free_extent_state(prealloc);
+ btrfs_free_extent_state(prealloc);
return ret;
}