diff options
| author |   Christian Brauner <brauner@kernel.org> | 2024-11-25 15:10:11 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-02 11:25:11 +0100 |
| commit | dfce6a462a9490063852c5d91d0f41104c0aad6d (patch) | |
| tree | 32b4da5f3967d892b4492686ae984227db27716f | |
| parent | nfs/nfs4idmap: avoid pointless reference count bump (diff) | |
| download | linux-rng-dfce6a462a9490063852c5d91d0f41104c0aad6d.tar.xz linux-rng-dfce6a462a9490063852c5d91d0f41104c0aad6d.zip | |
nfs/nfs4recover: avoid pointless cred reference count bump
The code already got rid of the extra reference count from the old
version of override_creds().
Link: https://lore.kernel.org/r/20241125-work-cred-v2-15-68b9d38bb5b2@kernel.org
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/nfsd/nfs4recover.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index f3837167b6a1..7f2ceeb118a4 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c @@ -81,8 +81,7 @@ nfs4_save_creds(const struct cred **original_creds) new->fsuid = GLOBAL_ROOT_UID; new->fsgid = GLOBAL_ROOT_GID; - *original_creds = override_creds(get_new_cred(new)); - put_cred(new); + *original_creds = override_creds(new); return 0; } |