diff options
| author |   Shuai Xue <xueshuai@linux.alibaba.com> | 2025-04-04 20:02:11 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2025-05-14 14:40:39 +0100 |
| commit | aa6f4f945b10eac57aed46154ae7d6fada7fccc7 (patch) | |
| tree | 0213dd702e201f3595f86dc39e5ecb22a20688c3 /drivers/dma | |
| parent | dmaengine: idxd: fix memory leak in error handling path of idxd_setup_engines (diff) | |
| download | linux-rng-aa6f4f945b10eac57aed46154ae7d6fada7fccc7.tar.xz linux-rng-aa6f4f945b10eac57aed46154ae7d6fada7fccc7.zip | |
dmaengine: idxd: fix memory leak in error handling path of idxd_setup_groups
Memory allocated for groups is not freed if an error occurs during
idxd_setup_groups(). To fix it, free the allocated memory in the reverse
order of allocation before exiting the function in case of an error.
Fixes: defe49f96012 ("dmaengine: idxd: fix group conf_dev lifetime")
Cc: stable@vger.kernel.org
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Link: https://lore.kernel.org/r/20250404120217.48772-4-xueshuai@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/idxd/init.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index ff6ec3c0f604..7f0a26e2e0a5 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -326,6 +326,7 @@ static int idxd_setup_groups(struct idxd_device *idxd) rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id); if (rc < 0) { put_device(conf_dev); + kfree(group); goto err; } @@ -350,7 +351,10 @@ static int idxd_setup_groups(struct idxd_device *idxd) while (--i >= 0) { group = idxd->groups[i]; put_device(group_confdev(group)); + kfree(group); } + kfree(idxd->groups); + return rc; } |