aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
diff options
context:
space:
mode:
authorIvan Lipski <ivlipski@amd.com>2024-05-29 13:47:53 -0400
committerAlex Deucher <alexander.deucher@amd.com>2024-06-14 16:18:25 -0400
commitfe6f61d4729780269b2a454fdd5b5e038f0db0e4 (patch)
treefa3bf680ace693b18b5d77dfb0eebba253af7053 /drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
parentdrm/amd/display: populate hardware_release hook for dcn401 (diff)
downloadlinux-rng-fe6f61d4729780269b2a454fdd5b5e038f0db0e4.tar.xz
linux-rng-fe6f61d4729780269b2a454fdd5b5e038f0db0e4.zip
drm/amd/display: Remove reduntant comparisons by Coverity
[WHY] Coverity analysis of the Upstream display driver code (amd-staging-drm-next) flagged these three functions as containing 'CONSTANT_EXPRESSION_RESULT' errors, i. e. the conditionals are reduntant since their result is predetermined. fixpt31_32.c: The two flagged 'ASSERT' lines redundant since they are always true: - LONG_MAX equals to the largest 'signed long long' number - res.value is type 'signed long long', So, the condition inside the 'ASSERTS's is always link_dp_training.c: The flagged conditional statement is always false: - 'max_requested.FFE_PRESET.settings.level' is 4 bits, so its max possible value is 15 - 'DP_FFE_PRESET_MAX_LEVEL' equals to 15. So, the conditional statement is always false and the wrapped code never executes. [HOW] Removed lines flagged by Coverity analysis. Reviewed-by: Sun peng Li <sunpeng.li@amd.com> Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com> Signed-off-by: Ivan Lipski <ivlipski@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c')
0 files changed, 0 insertions, 0 deletions