aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorQasim Ijaz <qasdev00@gmail.com>2025-03-27 23:11:46 +0000
committerJiri Kosina <jkosina@suse.com>2025-04-24 11:48:13 +0200
commit09d546303b370113323bfff456c4e8cff8756005 (patch)
tree69b0ab1af0017b3fea577020ec01258f9efabbca /drivers/hid
parentHID: hid-appletb-kbd: Fix wrong date and kernel version in sysfs interface docs (diff)
downloadlinux-rng-09d546303b370113323bfff456c4e8cff8756005.tar.xz
linux-rng-09d546303b370113323bfff456c4e8cff8756005.zip
HID: thrustmaster: fix memory leak in thrustmaster_interrupts()
In thrustmaster_interrupts(), the allocated send_buf is not freed if the usb_check_int_endpoints() check fails, leading to a memory leak. Fix this by ensuring send_buf is freed before returning in the error path. Fixes: 50420d7c79c3 ("HID: hid-thrustmaster: Fix warning in thrustmaster_probe by adding endpoint check") Signed-off-by: Qasim Ijaz <qasdev00@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-thrustmaster.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index 3b81468a1df2..0bf70664c35e 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -174,6 +174,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev)
u8 ep_addr[2] = {b_ep, 0};
if (!usb_check_int_endpoints(usbif, ep_addr)) {
+ kfree(send_buf);
hid_err(hdev, "Unexpected non-int endpoint\n");
return;
}