diff options
| author |   Jiri Slaby (SUSE) <jirislaby@kernel.org> | 2023-08-16 10:53:22 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-08-22 14:53:53 +0200 |
| commit | 2f4926723ac7343ae11861d0ba2aaa8e04bd3ca1 (patch) | |
| tree | d2f07bc30c764fc220b631f32a8e8112fafa34a9 /include/linux/tty_buffer.h | |
| parent | Merge commit b320441c04c9 ("Merge tag 'tty-6.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty") into tty-next (diff) | |
| download | linux-rng-2f4926723ac7343ae11861d0ba2aaa8e04bd3ca1.tar.xz linux-rng-2f4926723ac7343ae11861d0ba2aaa8e04bd3ca1.zip | |
tty: gdm724x: use min_t() for size_t varable and a constant
My thinking was that ulong is the same as size_t everywhere. No, size_t
is uint on 32bit. So the below commit introduced a build warning on
32bit:
.../gdm724x/gdm_tty.c:165:24: warning: comparison of distinct pointer types ('typeof (2048UL) *' (aka 'unsigned long *') and 'typeof (remain) *' (aka 'unsigned int *'))
To fix this, partially revert the commit (remove constants' suffixes)
and switch to min_t() in this case instead.
/me would hope for Z (or alike) suffix for constants.
Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Fixes: c3e5c706aefc (tty: gdm724x: convert counts to size_t)
Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308151953.rNNnAR2N-lkp@intel.com/
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
Link: https://lore.kernel.org/r/20230816085322.22065-1-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/tty_buffer.h')
0 files changed, 0 insertions, 0 deletions