diff options
author | 2023-03-02 20:14:42 -0800 | |
---|---|---|
committer | 2023-03-03 17:42:20 +0100 | |
commit | 8d093b4e95a2a16a2cfcd36869b348a17112fabe (patch) | |
tree | 76ee3f72594b752b3e289117a586312d1e50f051 /net/bpf | |
parent | bpf: Rename __kptr_ref -> __kptr and __kptr -> __kptr_untrusted. (diff) | |
download | linux-rng-8d093b4e95a2a16a2cfcd36869b348a17112fabe.tar.xz linux-rng-8d093b4e95a2a16a2cfcd36869b348a17112fabe.zip |
bpf: Mark cgroups and dfl_cgrp fields as trusted.
bpf programs sometimes do:
bpf_cgrp_storage_get(&map, task->cgroups->dfl_cgrp, ...);
It is safe to do, because cgroups->dfl_cgrp pointer is set diring init and
never changes. The task->cgroups is also never NULL. It is also set during init
and will change when task switches cgroups. For any trusted task pointer
dereference of cgroups and dfl_cgrp should yield trusted pointers. The verifier
wasn't aware of this. Hence in gcc compiled kernels task->cgroups dereference
was producing PTR_TO_BTF_ID without modifiers while in clang compiled kernels
the verifier recognizes __rcu tag in cgroups field and produces
PTR_TO_BTF_ID | MEM_RCU | MAYBE_NULL.
Tag cgroups and dfl_cgrp as trusted to equalize clang and gcc behavior.
When GCC supports btf_type_tag such tagging will done directly in the type.
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: David Vernet <void@manifault.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/bpf/20230303041446.3630-3-alexei.starovoitov@gmail.com
Diffstat (limited to 'net/bpf')
0 files changed, 0 insertions, 0 deletions