diff options
| author | 2026-09-18 15:16:18 +0200 | |
|---|---|---|
| committer | 2026-09-18 14:09:00 -0400 | |
| commit | 866dbd17c3d5f599b9d93ea9bd5b3d6859ff8350 (patch) | |
| tree | 20d74f19595c214d0aff292b15d976882c89a3f0 /scripts/Makefile.thinlto | |
| parent | drm/nouveau/clk: fix list cursor use after loop in nvkm_clk_ustate_update (diff) | |
drm/nouveau/clk: don't use the pstate cursor after the loop
nvkm_pstate_prog() walks clk->states looking for the entry at index
'pstatei' and then keeps using the list_for_each_entry cursor after the
loop. This is not triggerable today: every caller clamps the index
against clk->state_nr before calling, so the loop always breaks on a real
entry. It is safe by virtue of what the callers happen to do, not by
anything the function itself checks.
Should a caller ever pass an index that is not on the list, the cursor
would point at the list head rather than at a pstate, and the
pstate->base.domain[] and pstate->fanspeed accesses that follow would read
past it. Rather than leave that trap in place for the next caller, track
whether the entry was found and return -EINVAL if it was not.
No functional change.
Signed-off-by: Francesco Magazzu <postadelmaga@gmail.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patch.msgid.link/20260918131620.405133-3-postadelmaga@gmail.com
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
