diff options
| author |   Alexandre Mergnat <amergnat@baylibre.com> | 2025-04-28 12:06:48 +0200 |
|---|---|---|
| committer |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2025-06-02 00:10:18 +0200 |
| commit | fe9f5f96cfe8b82d0f24cbfa93718925560f4f8d (patch) | |
| tree | e405130cd1cc2e49aac5b230457c9bfff6ec5156 /scripts/gdb/linux/utils.py | |
| parent | rtc: Make rtc_time64_to_tm() support dates before 1970 (diff) | |
| download | linux-rng-fe9f5f96cfe8b82d0f24cbfa93718925560f4f8d.tar.xz linux-rng-fe9f5f96cfe8b82d0f24cbfa93718925560f4f8d.zip | |
rtc: Fix offset calculation for .start_secs < 0
The comparison
rtc->start_secs > rtc->range_max
has a signed left-hand side and an unsigned right-hand side.
So the comparison might become true for negative start_secs which is
interpreted as a (possibly very large) positive value.
As a negative value can never be bigger than an unsigned value
the correct representation of the (mathematical) comparison
rtc->start_secs > rtc->range_max
in C is:
rtc->start_secs >= 0 && rtc->start_secs > rtc->range_max
Use that to fix the offset calculation currently used in the
rtc-mt6397 driver.
Fixes: 989515647e783 ("rtc: Add one offset seconds to expand RTC range")
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20250428-enable-rtc-v4-2-2b2f7e3f9349@baylibre.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'scripts/gdb/linux/utils.py')
0 files changed, 0 insertions, 0 deletions