diff options
| author |   Marc Kleine-Budde <mkl@pengutronix.de> | 2025-05-06 15:55:19 +0200 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2025-05-06 15:55:19 +0200 |
| commit | f695e3083afe7db94d4e65a55be29e523280e4d7 (patch) | |
| tree | d4aaf0bca5e74a661277489734d3aa9909c8d821 /scripts/lib/kdoc/kdoc_files.py | |
| parent | can: mcp251xfd: fix TDC setting for low data bit rates (diff) | |
| parent | can: mcan: m_can_class_unregister(): fix order of unregistration calls (diff) | |
| download | linux-rng-f695e3083afe7db94d4e65a55be29e523280e4d7.tar.xz linux-rng-f695e3083afe7db94d4e65a55be29e523280e4d7.zip | |
Merge patch series "can: rx-offload: fix order of unregistration calls"
Marc Kleine-Budde <mkl@pengutronix.de> says:
If a driver is removed, the driver framework invokes the driver's
remove callback. A CAN driver's remove function calls
unregister_candev(), which calls net_device_ops::ndo_stop further down
in the call stack for interfaces which are in the "up" state.
With the mcp251xfd driver the removal of the module causes the
following warning:
| WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8
as can_rx_offload_del() deletes the NAPI, while it is still active,
because the interface is still up.
To fix the warning, first unregister the network interface, which
calls net_device_ops::ndo_stop, which disables the NAPI, and then call
can_rx_offload_del().
All other driver using the rx-offload helper have been checked and the
same issue has been found in the rockchip and m_can driver. These have
been fixed, but only compile time tested. On the mcp251xfd the fix was
tested on hardware.
Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-0-59a9b131589d@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_files.py')
0 files changed, 0 insertions, 0 deletions