diff options
| author |   NeilBrown <neilb@suse.de> | 2025-03-19 14:01:36 +1100 |
|---|---|---|
| committer |   Christian Brauner <brauner@kernel.org> | 2025-04-08 11:24:41 +0200 |
| commit | 06c567403ae5a0b56005c2d4a184c903f572c844 (patch) | |
| tree | 2240053af127cf0a802a5b05e805c5bea4ec6daf /security/selinux | |
| parent | VFS: rename lookup_one_len family to lookup_noperm and remove permission check (diff) | |
| download | linux-rng-06c567403ae5a0b56005c2d4a184c903f572c844.tar.xz linux-rng-06c567403ae5a0b56005c2d4a184c903f572c844.zip | |
Use try_lookup_noperm() instead of d_hash_and_lookup() outside of VFS
try_lookup_noperm() and d_hash_and_lookup() are nearly identical. The
former does some validation of the name where the latter doesn't.
Outside of the VFS that validation is likely valuable, and having only
one exported function for this task is certainly a good idea.
So make d_hash_and_lookup() local to VFS files and change all other
callers to try_lookup_noperm(). Note that the arguments are swapped.
Signed-off-by: NeilBrown <neilb@suse.de>
Link: https://lore.kernel.org/r/20250319031545.2999807-6-neil@brown.name
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'security/selinux')
| -rw-r--r-- | security/selinux/selinuxfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 47480eb2189b..e67a8ce4b64c 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -2158,8 +2158,8 @@ static int __init init_sel_fs(void) return err; } - selinux_null.dentry = d_hash_and_lookup(selinux_null.mnt->mnt_root, - &null_name); + selinux_null.dentry = try_lookup_noperm(&null_name, + selinux_null.mnt->mnt_root); if (IS_ERR(selinux_null.dentry)) { pr_err("selinuxfs: could not lookup null!\n"); err = PTR_ERR(selinux_null.dentry); |