aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Medina <davidmedina9@gmail.com>2011-11-16 01:52:33 +0100
committerDavid Medina <davidmedina9@gmail.com>2011-11-16 01:52:33 +0100
commit84a085138f69401bb5787916a530b59935c8dc19 (patch)
tree2cd1a72aa13c68af94ca118922117934a942308b
parentAPI change: Added gravatar_id in User model (diff)
downloadpython-github3-84a085138f69401bb5787916a530b59935c8dc19.tar.xz
python-github3-84a085138f69401bb5787916a530b59935c8dc19.zip
Fix 411 with PUT request
with data as None, requests module didn't add specific header
-rw-r--r--github3/api.py5
-rw-r--r--github3/tests/api_test.py9
2 files changed, 12 insertions, 2 deletions
diff --git a/github3/api.py b/github3/api.py
index 1c467ff..a4ee4a9 100644
--- a/github3/api.py
+++ b/github3/api.py
@@ -72,8 +72,9 @@ class GithubCore(object):
def put(self, request, **kwargs):
""" PUT request """
- # Content-length: 0 to headers ?
- response = self._request('PUT', request, **kwargs)
+
+ response = self._request('PUT', request,
+ headers={'Content-length': '0'}, **kwargs)
assert response.status_code == 204
return response
diff --git a/github3/tests/api_test.py b/github3/tests/api_test.py
index 258a737..3ae75ee 100644
--- a/github3/tests/api_test.py
+++ b/github3/tests/api_test.py
@@ -113,3 +113,12 @@ class TestGithubCore(TestCase):
delete = self.gh.delete('core')
request_method.assert_called_with(
'DELETE', self.base_url + 'core')
+
+ def test_put(self, request_method):
+ response = request_method.return_value
+ response.status_code = 204
+ response.content = ''
+ put = self.gh.put('core')
+ request_method.assert_called_with(
+ 'PUT', self.base_url + 'core',
+ headers={'Content-length': '0'})