diff options
| author |   Paolo Bonzini <pbonzini@redhat.com> | 2017-12-07 20:13:15 +0000 |
|---|---|---|
| committer |   Stefan Hajnoczi <stefanha@redhat.com> | 2017-12-19 10:25:09 +0000 |
| commit | bd6458e410c1e7d2912357aeb399fe7d8ee9f9a3 (patch) | |
| tree | 67e60c6baf30b7a210719b7c92d50b15ce5079bb /hw/misc/omap_clk.c | |
| parent | virtio-blk: reject configs with logical block size > physical block size (diff) | |
| download | qemu-bd6458e410c1e7d2912357aeb399fe7d8ee9f9a3.tar.xz qemu-bd6458e410c1e7d2912357aeb399fe7d8ee9f9a3.zip | |
block: avoid recursive AioContext acquire in bdrv_inactivate_all()
BDRV_POLL_WHILE() does not support recursive AioContext locking. It
only releases the AioContext lock once regardless of how many times the
caller has acquired it. This results in a hang since the IOThread does
not make progress while the AioContext is still locked.
The following steps trigger the hang:
$ qemu-system-x86_64 -M accel=kvm -m 1G -cpu host \
-object iothread,id=iothread0 \
-device virtio-scsi-pci,iothread=iothread0 \
-drive if=none,id=drive0,file=test.img,format=raw \
-device scsi-hd,drive=drive0 \
-drive if=none,id=drive1,file=test.img,format=raw \
-device scsi-hd,drive=drive1
$ qemu-system-x86_64 ...same options... \
-incoming tcp::1234
(qemu) migrate tcp:127.0.0.1:1234
...hang...
Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20171207201320.19284-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/misc/omap_clk.c')
0 files changed, 0 insertions, 0 deletions