diff options
author | 2017-02-26 23:43:00 +0100 | |
---|---|---|
committer | 2017-02-28 11:21:15 +0100 | |
commit | df4938a6651b1f980018f9eaf86af43e6b9d7fed (patch) | |
tree | 1525239f0724b2b9ff84c84153927ef5a8f45021 /scripts/qapi-commands.py | |
parent | 9pfs: local: lremovexattr: don't follow symlinks (diff) | |
download | qemu-df4938a6651b1f980018f9eaf86af43e6b9d7fed.tar.xz qemu-df4938a6651b1f980018f9eaf86af43e6b9d7fed.zip |
9pfs: local: unlinkat: don't follow symlinks
The local_unlinkat() callback is vulnerable to symlink attacks because it
calls remove() which follows symbolic links in all path elements but the
rightmost one.
This patch converts local_unlinkat() to rely on opendir_nofollow() and
unlinkat() instead.
Most of the code is moved to a separate local_unlinkat_common() helper
which will be reused in a subsequent patch to fix the same issue in
local_remove().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'scripts/qapi-commands.py')
0 files changed, 0 insertions, 0 deletions