diff options
author | 2014-05-02 13:26:42 +0200 | |
---|---|---|
committer | 2014-05-09 09:11:32 -0400 | |
commit | ab31979a7e835832605f8425d0eaa5c74d1e6375 (patch) | |
tree | a6c1fad34ebab86f90803ce8c57e539637a37734 /scripts/qapi.py | |
parent | dump: Drop pointless error_is_set(), DumpState member errp (diff) | |
download | qemu-ab31979a7e835832605f8425d0eaa5c74d1e6375.tar.xz qemu-ab31979a7e835832605f8425d0eaa5c74d1e6375.zip |
qmp: Don't use error_is_set() to suppress additional errors
Using error_is_set(errp) that way can sweep programming errors under
the carpet when we get called incorrectly with an error set.
encrypted_bdrv_it() does it, because there's no way to make
bdrv_iterate() break its loop. Actually safe, because qmp_cont()
clears the error before the loop. Clean it up anyway: replace
bdrv_iterate() by bdrv_next(), break the loop on error.
Replace both occurrences, for consistency.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'scripts/qapi.py')
0 files changed, 0 insertions, 0 deletions