aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/qapi
diff options
context:
space:
mode:
authorAvihai Horon <avihaih@nvidia.com>2024-01-25 18:25:12 +0200
committerPeter Xu <peterx@redhat.com>2024-02-07 09:53:00 +0800
commit3205bebd4fc6dd501fb8b10c93ddce9da18e09db (patch)
tree929079d8628442605e057ab9cf4eedef6e9ca087 /scripts/qapi
parentmigration/multifd: Optimize sender side to be lockless (diff)
downloadqemu-3205bebd4fc6dd501fb8b10c93ddce9da18e09db.tar.xz
qemu-3205bebd4fc6dd501fb8b10c93ddce9da18e09db.zip
migration: Fix logic of channels and transport compatibility check
The commit in the fixes line mistakenly modified the channels and transport compatibility check logic so it now checks multi-channel support only for socket transport type. Thus, running multifd migration using a transport other than socket that is incompatible with multi-channels (such as "exec") would lead to a segmentation fault instead of an error message. For example: (qemu) migrate_set_capability multifd on (qemu) migrate -d "exec:cat > /tmp/vm_state" Segmentation fault (core dumped) Fix it by checking multi-channel compatibility for all transport types. Cc: qemu-stable <qemu-stable@nongnu.org> Fixes: d95533e1cdcc ("migration: modify migration_channels_and_uri_compatible() for new QAPI syntax") Signed-off-by: Avihai Horon <avihaih@nvidia.com> Reviewed-by: Peter Xu <peterx@redhat.com> Link: https://lore.kernel.org/r/20240125162528.7552-2-avihaih@nvidia.com Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'scripts/qapi')
0 files changed, 0 insertions, 0 deletions