summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Braun <martin.braun@ettus.com>2019-01-18 13:54:48 -0800
committerBrent Stapleton <brent.stapleton@ettus.com>2019-01-22 18:16:59 -0800
commitec2cad0346a7e459222d976a2cb4de34339aa3ae (patch)
tree8fe7e1a69588c3baf1a2c02b4040c8bee48e014c
parentformatting: Apply clang-format to nocscript files (diff)
downloaduhd-ec2cad0346a7e459222d976a2cb4de34339aa3ae.tar.xz
uhd-ec2cad0346a7e459222d976a2cb4de34339aa3ae.zip
lib: rfnoc: Add some missing virtual destructors
-rw-r--r--host/lib/rfnoc/blockdef_xml_impl.cpp2
-rw-r--r--host/lib/rfnoc/nocscript/expression.hpp6
-rw-r--r--host/lib/rfnoc/nocscript/parser.cpp2
3 files changed, 8 insertions, 2 deletions
diff --git a/host/lib/rfnoc/blockdef_xml_impl.cpp b/host/lib/rfnoc/blockdef_xml_impl.cpp
index db491922c..2326043ca 100644
--- a/host/lib/rfnoc/blockdef_xml_impl.cpp
+++ b/host/lib/rfnoc/blockdef_xml_impl.cpp
@@ -242,6 +242,8 @@ public:
}
}
+ virtual ~blockdef_xml_impl() {}
+
bool is_block() const
{
return _type == DESCRIBES_BLOCK;
diff --git a/host/lib/rfnoc/nocscript/expression.hpp b/host/lib/rfnoc/nocscript/expression.hpp
index becc329f0..309741295 100644
--- a/host/lib/rfnoc/nocscript/expression.hpp
+++ b/host/lib/rfnoc/nocscript/expression.hpp
@@ -72,6 +72,8 @@ public:
//! Create an int vector literal expression from a C++ vector<int>.
expression_literal(std::vector<int> v);
+ virtual ~expression_literal() {}
+
expression::type_t infer_type() const
{
return _type;
@@ -192,7 +194,7 @@ public:
//! Create an empty container
expression_container() : _combiner(COMBINE_NOTSET){};
- virtual ~expression_container(){};
+ virtual ~expression_container() {}
/*! Type-deduction rules for containers are:
* - If the combination type is COMBINE_ALL or COMBINE_AND,
@@ -331,6 +333,8 @@ public:
type_getter_type type_getter,
value_getter_type value_getter);
+ virtual ~expression_variable() {}
+
/*! Looks up the variable type in the variable table.
*
* \throws Depending on \p type_getter, this may throw when the variable does not
diff --git a/host/lib/rfnoc/nocscript/parser.cpp b/host/lib/rfnoc/nocscript/parser.cpp
index f34d475ba..51a544e47 100644
--- a/host/lib/rfnoc/nocscript/parser.cpp
+++ b/host/lib/rfnoc/nocscript/parser.cpp
@@ -34,7 +34,7 @@ public:
// nop
}
- ~parser_impl(){};
+ virtual ~parser_impl() {}
/******************************************************************