diff options
| author |   Trygve Aaberge <trygveaa@gmail.com> | 2022-10-08 17:42:22 +0200 |
|---|---|---|
| committer |   Sébastien Helleu <flashcode@flashtux.org> | 2022-10-08 18:13:00 +0200 |
| commit | fdb1ff3781bec69799073f55fcc515636fe462d8 (patch) | |
| tree | 5bca32e3b71346a387dd80a32147cc0bfe71ea00 | |
| parent | core: fix compilation warning on isdigit function (diff) | |
| download | weechat-fdb1ff3781bec69799073f55fcc515636fe462d8.tar.xz weechat-fdb1ff3781bec69799073f55fcc515636fe462d8.zip | |
tests: Use LONGS_EQUAL for version number tests
util_version_number returns an int, but BYTES_EQUAL only compares the
last byte of the int, so it wouldn't test the rest of the int.
I see other tests for functions returning an int use LONGS_EQUAL, so
that seems correct to use.
| -rw-r--r-- | tests/unit/core/test-core-util.cpp | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/tests/unit/core/test-core-util.cpp b/tests/unit/core/test-core-util.cpp index 768ad5c48..7db5f0f5b 100644 --- a/tests/unit/core/test-core-util.cpp +++ b/tests/unit/core/test-core-util.cpp @@ -229,19 +229,19 @@ TEST(CoreUtil, ParseDelay) TEST(CoreUtil, VersionNumber) { - BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-dev")); - BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-rc1")); - BYTES_EQUAL(0x00030200, util_version_number ("0.3.2")); - BYTES_EQUAL(0x00030101, util_version_number ("0.3.1.1")); - BYTES_EQUAL(0x00030100, util_version_number ("0.3.1")); - BYTES_EQUAL(0x00030000, util_version_number ("0.3.0")); - BYTES_EQUAL(0x01000000, util_version_number ("1.0")); - BYTES_EQUAL(0x01000000, util_version_number ("1.0.0")); - BYTES_EQUAL(0x01000000, util_version_number ("1.0.0.0")); - BYTES_EQUAL(0x01000100, util_version_number ("1.0.1")); - BYTES_EQUAL(0x01000200, util_version_number ("1.0.2")); - BYTES_EQUAL(0x01010000, util_version_number ("1.1")); - BYTES_EQUAL(0x01010100, util_version_number ("1.1.1")); - BYTES_EQUAL(0x01010200, util_version_number ("1.1.2")); - BYTES_EQUAL(0x01020304, util_version_number ("1.2.3.4")); + LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-dev")); + LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-rc1")); + LONGS_EQUAL(0x00030200, util_version_number ("0.3.2")); + LONGS_EQUAL(0x00030101, util_version_number ("0.3.1.1")); + LONGS_EQUAL(0x00030100, util_version_number ("0.3.1")); + LONGS_EQUAL(0x00030000, util_version_number ("0.3.0")); + LONGS_EQUAL(0x01000000, util_version_number ("1.0")); + LONGS_EQUAL(0x01000000, util_version_number ("1.0.0")); + LONGS_EQUAL(0x01000000, util_version_number ("1.0.0.0")); + LONGS_EQUAL(0x01000100, util_version_number ("1.0.1")); + LONGS_EQUAL(0x01000200, util_version_number ("1.0.2")); + LONGS_EQUAL(0x01010000, util_version_number ("1.1")); + LONGS_EQUAL(0x01010100, util_version_number ("1.1.1")); + LONGS_EQUAL(0x01010200, util_version_number ("1.1.2")); + LONGS_EQUAL(0x01020304, util_version_number ("1.2.3.4")); } |