diff options
author | Harsh Shandilya <harsh@prjkt.io> | 2018-05-05 16:26:52 +0530 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2018-05-09 18:16:14 +0200 |
commit | fda527c659e2fa4bff1e2806795877d0004d24d9 (patch) | |
tree | e7e66720eca79145348adb82b763a0ee10685b3a /app/src/main/java/com/wireguard/android/activity/SettingsActivity.java | |
parent | MainActivity: Nip out as early as possible when moving to same fragment (diff) | |
download | wireguard-android-fda527c659e2fa4bff1e2806795877d0004d24d9.tar.xz wireguard-android-fda527c659e2fa4bff1e2806795877d0004d24d9.zip |
global: Cleanup line lengths and misc lint warnings
I know we decided to ditch the idea of shutting up "Exception
thrown with empty param" warnings but this pesters me too
much and we can instead just treat this as a weird future proofing
thing if and when we end up needing the exception messages.
Signed-off-by: Harsh Shandilya <harsh@prjkt.io>
Diffstat (limited to 'app/src/main/java/com/wireguard/android/activity/SettingsActivity.java')
-rw-r--r-- | app/src/main/java/com/wireguard/android/activity/SettingsActivity.java | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/app/src/main/java/com/wireguard/android/activity/SettingsActivity.java b/app/src/main/java/com/wireguard/android/activity/SettingsActivity.java index 3d85e30b..2507db67 100644 --- a/app/src/main/java/com/wireguard/android/activity/SettingsActivity.java +++ b/app/src/main/java/com/wireguard/android/activity/SettingsActivity.java @@ -10,6 +10,7 @@ import android.content.pm.PackageManager; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.v4.app.ActivityCompat; +import android.support.v4.content.ContextCompat; import android.support.v7.app.AppCompatActivity; import android.support.v7.preference.Preference; import android.support.v7.preference.PreferenceFragmentCompat; @@ -36,7 +37,8 @@ public class SettingsActivity extends AppCompatActivity { public void ensurePermissions(final String[] permissions, final PermissionRequestCallback cb) { final List<String> needPermissions = new ArrayList<>(permissions.length); for (final String permission : permissions) { - if (ActivityCompat.checkSelfPermission(this, permission) != PackageManager.PERMISSION_GRANTED) + if (ContextCompat.checkSelfPermission(this, permission) + != PackageManager.PERMISSION_GRANTED) needPermissions.add(permission); } if (needPermissions.isEmpty()) { @@ -47,7 +49,8 @@ public class SettingsActivity extends AppCompatActivity { } final int idx = permissionRequestCounter++; permissionRequestCallbacks.put(idx, cb); - ActivityCompat.requestPermissions(this, needPermissions.toArray(new String[needPermissions.size()]), idx); + ActivityCompat.requestPermissions(this, + needPermissions.toArray(new String[needPermissions.size()]), idx); } @Override @@ -72,7 +75,9 @@ public class SettingsActivity extends AppCompatActivity { } @Override - public void onRequestPermissionsResult(final int requestCode, @NonNull final String[] permissions, @NonNull final int[] grantResults) { + public void onRequestPermissionsResult(final int requestCode, + @NonNull final String[] permissions, + @NonNull final int[] grantResults) { final PermissionRequestCallback f = permissionRequestCallbacks.get(requestCode); if (f != null) { permissionRequestCallbacks.remove(requestCode); |