aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2018-12-19 00:35:53 +0100
committerJason A. Donenfeld <Jason@zx2c4.com>2018-12-19 00:35:53 +0100
commita8326ae753975e73602958c1d7bbfe1174912ff9 (patch)
tree808003d8f9da84b5131b9f517fb04f492365abdd
parentFreebsd is finally normal in sys/unix (diff)
downloadwireguard-go-a8326ae753975e73602958c1d7bbfe1174912ff9.tar.xz
wireguard-go-a8326ae753975e73602958c1d7bbfe1174912ff9.zip
Make error messages consistent
-rw-r--r--receive.go5
-rw-r--r--send.go2
-rw-r--r--timers.go8
3 files changed, 9 insertions, 6 deletions
diff --git a/receive.go b/receive.go
index b07d479..b22abf5 100644
--- a/receive.go
+++ b/receive.go
@@ -351,7 +351,10 @@ func (device *Device) RoutineHandshake() {
// consume reply
if peer := entry.peer; peer.isRunning.Get() {
- peer.cookieGenerator.ConsumeReply(&reply)
+ logDebug.Println("Receiving cookie response from ", elem.endpoint.DstToString())
+ if !peer.cookieGenerator.ConsumeReply(&reply) {
+ logDebug.Println("Could not decrypt invalid cookie response")
+ }
}
continue
diff --git a/send.go b/send.go
index 07e43e1..6edc6d7 100644
--- a/send.go
+++ b/send.go
@@ -206,7 +206,7 @@ func (peer *Peer) SendHandshakeResponse() error {
func (device *Device) SendHandshakeCookie(initiatingElem *QueueHandshakeElement) error {
- device.log.Debug.Println("Sending cookie reply to:", initiatingElem.endpoint.DstToString())
+ device.log.Debug.Println("Sending cookie response for denied handshake message for", initiatingElem.endpoint.DstToString())
sender := binary.LittleEndian.Uint32(initiatingElem.packet[4:8])
reply, err := device.cookieChecker.CreateReply(initiatingElem.packet, sender, initiatingElem.endpoint.DstToBytes())
diff --git a/timers.go b/timers.go
index 0a9c739..266e422 100644
--- a/timers.go
+++ b/timers.go
@@ -79,7 +79,7 @@ func (peer *Peer) timersActive() bool {
func expiredRetransmitHandshake(peer *Peer) {
if atomic.LoadUint32(&peer.timers.handshakeAttempts) > MaxTimerHandshakes {
- peer.device.log.Debug.Printf("%s: Handshake did not complete after %d attempts, giving up\n", peer, MaxTimerHandshakes+2)
+ peer.device.log.Debug.Printf("%s - Handshake did not complete after %d attempts, giving up\n", peer, MaxTimerHandshakes+2)
if peer.timersActive() {
peer.timers.sendKeepalive.Del()
@@ -98,7 +98,7 @@ func expiredRetransmitHandshake(peer *Peer) {
}
} else {
atomic.AddUint32(&peer.timers.handshakeAttempts, 1)
- peer.device.log.Debug.Printf("%s: Handshake did not complete after %d seconds, retrying (try %d)\n", peer, int(RekeyTimeout.Seconds()), atomic.LoadUint32(&peer.timers.handshakeAttempts)+1)
+ peer.device.log.Debug.Printf("%s - Handshake did not complete after %d seconds, retrying (try %d)\n", peer, int(RekeyTimeout.Seconds()), atomic.LoadUint32(&peer.timers.handshakeAttempts)+1)
/* We clear the endpoint address src address, in case this is the cause of trouble. */
peer.mutex.Lock()
@@ -122,7 +122,7 @@ func expiredSendKeepalive(peer *Peer) {
}
func expiredNewHandshake(peer *Peer) {
- peer.device.log.Debug.Printf("%s: Retrying handshake because we stopped hearing back after %d seconds\n", peer, int((KeepaliveTimeout + RekeyTimeout).Seconds()))
+ peer.device.log.Debug.Printf("%s - Retrying handshake because we stopped hearing back after %d seconds\n", peer, int((KeepaliveTimeout + RekeyTimeout).Seconds()))
/* We clear the endpoint address src address, in case this is the cause of trouble. */
peer.mutex.Lock()
if peer.endpoint != nil {
@@ -134,7 +134,7 @@ func expiredNewHandshake(peer *Peer) {
}
func expiredZeroKeyMaterial(peer *Peer) {
- peer.device.log.Debug.Printf("%s: Removing all keys, since we haven't received a new one in %d seconds\n", peer, int((RejectAfterTime * 3).Seconds()))
+ peer.device.log.Debug.Printf("%s - Removing all keys, since we haven't received a new one in %d seconds\n", peer, int((RejectAfterTime * 3).Seconds()))
peer.ZeroAndFlushAll()
}