diff options
author | 2025-02-19 11:44:35 +0100 | |
---|---|---|
committer | 2025-04-24 17:38:07 -0500 | |
commit | 0248bfb2557932b27d3e1375a3dc6902127b42bc (patch) | |
tree | 022d67213a2fa094e29127bc1552a7147547fadc | |
parent | clk: socfpga: clk-pll: Optimize local variables (diff) | |
download | wireguard-linux-0248bfb2557932b27d3e1375a3dc6902127b42bc.tar.xz wireguard-linux-0248bfb2557932b27d3e1375a3dc6902127b42bc.zip |
clk: socfpga: stratix10: Optimize local variables
Since readl() returns a u32, the local variable reg can also have the
data type u32. Furthermore, mdiv and refdiv are derived from reg and can
also be a u32.
Since do_div() casts the divisor to u32 anyway, changing the data type
of refdiv to u32 removes the following Coccinelle/coccicheck warning
reported by do_div.cocci:
WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead
Compile-tested only.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
-rw-r--r-- | drivers/clk/socfpga/clk-pll-s10.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/clk/socfpga/clk-pll-s10.c b/drivers/clk/socfpga/clk-pll-s10.c index 1d82737befd3..a88c212bda12 100644 --- a/drivers/clk/socfpga/clk-pll-s10.c +++ b/drivers/clk/socfpga/clk-pll-s10.c @@ -83,9 +83,9 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hwclk, unsigned long parent_rate) { struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk); - unsigned long mdiv; - unsigned long refdiv; - unsigned long reg; + u32 mdiv; + u32 refdiv; + u32 reg; unsigned long long vco_freq; /* read VCO1 reg for numerator and denominator */ |