diff options
| author |   Hans de Goede <hdegoede@redhat.com> | 2023-06-19 12:52:06 +0200 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-09-27 09:40:02 +0200 |
| commit | 0e2c53ff13e2240dea196d5813cc08ea923951dc (patch) | |
| tree | ad0e75a2938551038b0bc846f73b08c797969337 | |
| parent | media: atomisp: sh_css_internal: sh_css_params: Unifying sh_css_sp_group data structure (diff) | |
| download | wireguard-linux-0e2c53ff13e2240dea196d5813cc08ea923951dc.tar.xz wireguard-linux-0e2c53ff13e2240dea196d5813cc08ea923951dc.zip | |
media: atomisp: Fix missing v4l2_fh_release() in atomisp_open() error exit
Fix missing v4l2_fh_release() in atomisp_open()'s
"if (pipe->users)" error exit path.
Closes: https://lore.kernel.org/r/202306180511.XWN0Hr7F-lkp@intel.com/
Link: https://lore.kernel.org/r/20230619105212.303653-1-hdegoede@redhat.com
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_fops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c index 54466d2f323a..a09087dccbcb 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c @@ -513,8 +513,8 @@ static int atomisp_open(struct file *file) */ if (pipe->users) { dev_dbg(isp->dev, "video node already opened\n"); - mutex_unlock(&isp->mutex); - return -EBUSY; + ret = -EBUSY; + goto error; } /* runtime power management, turn on ISP */ |