diff options
| author |   Diederik de Haas <didi.debian@cknow.org> | 2025-04-17 16:21:18 +0200 |
|---|---|---|
| committer |   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> | 2025-04-27 23:04:33 +0530 |
| commit | 286ed198b899739862456f451eda884558526a9d (patch) | |
| tree | 581d57ac9bb9bfd98985563848087f32b45dea78 | |
| parent | PCI: dw-rockchip: Use rockchip_pcie_link_up() to check link up instead of open coding (diff) | |
| download | wireguard-linux-286ed198b899739862456f451eda884558526a9d.tar.xz wireguard-linux-286ed198b899739862456f451eda884558526a9d.zip | |
PCI: dw-rockchip: Fix PHY function call sequence in rockchip_pcie_phy_deinit()
The documentation for the phy_power_off() function explicitly says that it
must be called before phy_exit().
Hence, follow the same rule in rockchip_pcie_phy_deinit().
Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
[mani: commit message change]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
Cc: stable@vger.kernel.org # v5.15+
Link: https://patch.msgid.link/20250417142138.1377451-1-didi.debian@cknow.org
| -rw-r--r-- | drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index bfc47dab32e5..3c6ab71c996e 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -431,8 +431,8 @@ static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip) static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip) { - phy_exit(rockchip->phy); phy_power_off(rockchip->phy); + phy_exit(rockchip->phy); } static const struct dw_pcie_ops dw_pcie_ops = { |