diff options
| author |   Binbin Wu <binbin.wu@linux.intel.com> | 2023-10-16 14:24:46 +0800 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2023-10-16 11:39:57 +0200 |
| commit | 29060633411a02f6f2dd9d5245919385d69d81f0 (patch) | |
| tree | 46918fa25b56809a0ff41e58ea2a005c2280de6b | |
| parent | x86/sev: Drop unneeded #include (diff) | |
| download | wireguard-linux-29060633411a02f6f2dd9d5245919385d69d81f0.tar.xz wireguard-linux-29060633411a02f6f2dd9d5245919385d69d81f0.zip | |
selftests/x86/lam: Zero out buffer for readlink()
Zero out the buffer for readlink() since readlink() does not append a
terminating null byte to the buffer. Also change the buffer length
passed to readlink() to 'PATH_MAX - 1' to ensure the resulting string
is always null terminated.
Fixes: 833c12ce0f430 ("selftests/x86/lam: Add inherit test cases for linear-address masking")
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Link: https://lore.kernel.org/r/20231016062446.695-1-binbin.wu@linux.intel.com
| -rw-r--r-- | tools/testing/selftests/x86/lam.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c index eb0e46905bf9..8f9b06d9ce03 100644 --- a/tools/testing/selftests/x86/lam.c +++ b/tools/testing/selftests/x86/lam.c @@ -573,7 +573,7 @@ int do_uring(unsigned long lam) char path[PATH_MAX] = {0}; /* get current process path */ - if (readlink("/proc/self/exe", path, PATH_MAX) <= 0) + if (readlink("/proc/self/exe", path, PATH_MAX - 1) <= 0) return 1; int file_fd = open(path, O_RDONLY); @@ -680,14 +680,14 @@ static int handle_execve(struct testcases *test) perror("Fork failed."); ret = 1; } else if (pid == 0) { - char path[PATH_MAX]; + char path[PATH_MAX] = {0}; /* Set LAM mode in parent process */ if (set_lam(lam) != 0) return 1; /* Get current binary's path and the binary was run by execve */ - if (readlink("/proc/self/exe", path, PATH_MAX) <= 0) + if (readlink("/proc/self/exe", path, PATH_MAX - 1) <= 0) exit(-1); /* run binary to get LAM mode and return to parent process */ |