diff options
| author |   Juergen Gross <jgross@suse.com> | 2024-11-08 17:14:16 +0100 |
|---|---|---|
| committer |   Sean Christopherson <seanjc@google.com> | 2024-12-16 15:27:34 -0800 |
| commit | 2d5faa6a8402435d6332e8e8f3c3f18cca382d83 (patch) | |
| tree | fc4bef208974c3a51c9fbe1bfba13713eacc3fac | |
| parent | Merge tag 'kvm-riscv-fixes-6.13-1' of https://github.com/kvm-riscv/linux into HEAD (diff) | |
| download | wireguard-linux-2d5faa6a8402435d6332e8e8f3c3f18cca382d83.tar.xz wireguard-linux-2d5faa6a8402435d6332e8e8f3c3f18cca382d83.zip | |
KVM/x86: add comment to kvm_mmu_do_page_fault()
On a first glance it isn't obvious why calling kvm_tdp_page_fault() in
kvm_mmu_do_page_fault() is special cased, as the general case of using
an indirect case would result in calling of kvm_tdp_page_fault()
anyway.
Add a comment to explain the reason.
Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20241108161416.28552-1-jgross@suse.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
| -rw-r--r-- | arch/x86/kvm/mmu/mmu_internal.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h index b00abbe3f6cf..72de71f4bc8b 100644 --- a/arch/x86/kvm/mmu/mmu_internal.h +++ b/arch/x86/kvm/mmu/mmu_internal.h @@ -321,6 +321,10 @@ static inline int kvm_mmu_do_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, fault.slot = kvm_vcpu_gfn_to_memslot(vcpu, fault.gfn); } + /* + * With retpoline being active an indirect call is rather expensive, + * so do a direct call in the most common case. + */ if (IS_ENABLED(CONFIG_MITIGATION_RETPOLINE) && fault.is_tdp) r = kvm_tdp_page_fault(vcpu, &fault); else |