aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorOleksij Rempel <o.rempel@pengutronix.de>2024-12-09 14:07:45 +0100
committerJakub Kicinski <kuba@kernel.org>2024-12-10 18:50:58 -0800
commit41b774e4f3279a3b3149a36fe27557ecdc72c29c (patch)
tree71a261bd27b6377153b511585bc4c9bc4138f646
parentnet: usb: lan78xx: Add error handling to lan78xx_set_mac_addr (diff)
downloadwireguard-linux-41b774e4f3279a3b3149a36fe27557ecdc72c29c.tar.xz
wireguard-linux-41b774e4f3279a3b3149a36fe27557ecdc72c29c.zip
net: usb: lan78xx: Simplify lan78xx_update_reg
Simplify `lan78xx_update_reg` by directly returning the result of `lan78xx_write_reg`. This eliminates unnecessary checks and improves code readability. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20241209130751.703182-6-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/usb/lan78xx.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 5d318ff8b33d..442b6ee2dd46 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -674,11 +674,7 @@ static int lan78xx_update_reg(struct lan78xx_net *dev, u32 reg, u32 mask,
buf &= ~mask;
buf |= (mask & data);
- ret = lan78xx_write_reg(dev, reg, buf);
- if (ret < 0)
- return ret;
-
- return 0;
+ return lan78xx_write_reg(dev, reg, buf);
}
static int lan78xx_read_stats(struct lan78xx_net *dev,