diff options
| author |   Aaron Tomlin <atomlin@redhat.com> | 2022-10-07 14:38:12 +0100 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2022-10-10 12:16:19 -0700 |
| commit | 47cc75aa92837a9d3f15157d6272ff285585d75d (patch) | |
| tree | 348abc250461d8b242d481cbe6bd038f23972e70 | |
| parent | Merge tag 'modules-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux (diff) | |
| download | wireguard-linux-47cc75aa92837a9d3f15157d6272ff285585d75d.tar.xz wireguard-linux-47cc75aa92837a9d3f15157d6272ff285585d75d.zip | |
module: tracking: Keep a record of tainted unloaded modules only
This ensures that no module record/or entry is added to the
unloaded_tainted_modules list if it does not carry a taint.
Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Fixes: 99bd9956551b ("module: Introduce module unload taint tracking")
Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | kernel/module/tracking.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/module/tracking.c b/kernel/module/tracking.c index a139e63b6f20..26d812e07615 100644 --- a/kernel/module/tracking.c +++ b/kernel/module/tracking.c @@ -22,6 +22,9 @@ int try_add_tainted_module(struct module *mod) module_assert_mutex_or_preempt(); + if (!mod->taints) + goto out; + list_for_each_entry_rcu(mod_taint, &unloaded_tainted_modules, list, lockdep_is_held(&module_mutex)) { if (!strcmp(mod_taint->name, mod->name) && |