diff options
| author |   Filipe Manana <fdmanana@suse.com> | 2024-12-18 12:36:21 +0000 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2025-01-13 14:53:19 +0100 |
| commit | 4866812020a27dee7cb8e94dc9e13a2793ae966a (patch) | |
| tree | 90785f799c694206d77a6dc826324d5ff3ae4080 | |
| parent | btrfs: dev-replace: remove unnecessary call to btrfs_mark_buffer_dirty() (diff) | |
| download | wireguard-linux-4866812020a27dee7cb8e94dc9e13a2793ae966a.tar.xz wireguard-linux-4866812020a27dee7cb8e94dc9e13a2793ae966a.zip | |
btrfs: dir-item: remove unnecessary calls to btrfs_mark_buffer_dirty()
We have several places explicitly calling btrfs_mark_buffer_dirty() but
that is not necessarily since the target leaf came from a path that was
obtained for a btree search function that modifies the btree, something
like btrfs_insert_empty_item() or anything else that ends up calling
btrfs_search_slot() with a value of 1 for its 'cow' argument.
These just make the code more verbose, confusing and add a little extra
overhead and well as increase the module's text size, so remove them.
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/dir-item.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c index 1ea5d8fcfbf7..ccf91de29f80 100644 --- a/fs/btrfs/dir-item.c +++ b/fs/btrfs/dir-item.c @@ -92,7 +92,6 @@ int btrfs_insert_xattr_item(struct btrfs_trans_handle *trans, write_extent_buffer(leaf, name, name_ptr, name_len); write_extent_buffer(leaf, data, data_ptr, data_len); - btrfs_mark_buffer_dirty(trans, path->nodes[0]); return ret; } @@ -152,7 +151,6 @@ int btrfs_insert_dir_item(struct btrfs_trans_handle *trans, name_ptr = (unsigned long)(dir_item + 1); write_extent_buffer(leaf, name->name, name_ptr, name->len); - btrfs_mark_buffer_dirty(trans, leaf); second_insert: /* FIXME, use some real flag for selecting the extra index */ |