aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorWolfram Sang <wsa+renesas@sang-engineering.com>2022-07-13 22:46:17 +0200
committerShuah Khan <skhan@linuxfoundation.org>2022-07-14 14:36:24 -0600
commit4d8f52ac5fa9eede7b7aa2f2d67c841d9eeb655f (patch)
tree28c786d296f297eb13f9dd182ad6ecf1659eeabc
parentselftests: timers: inconsistency-check: adapt to kselftest framework (diff)
downloadwireguard-linux-4d8f52ac5fa9eede7b7aa2f2d67c841d9eeb655f.tar.xz
wireguard-linux-4d8f52ac5fa9eede7b7aa2f2d67c841d9eeb655f.zip
selftests: timers: clocksource-switch: fix passing errors from child
The return value from system() is a waitpid-style integer. Do not return it directly because with the implicit masking in exit() it will always return 0. Access it with appropriate macros to really pass on errors. Fixes: 7290ce1423c3 ("selftests/timers: Add clocksource-switch test from timetest suite") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: John Stultz <jstultz@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
-rw-r--r--tools/testing/selftests/timers/clocksource-switch.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c
index ef8eb3604595..b57f0a9be490 100644
--- a/tools/testing/selftests/timers/clocksource-switch.c
+++ b/tools/testing/selftests/timers/clocksource-switch.c
@@ -110,10 +110,10 @@ int run_tests(int secs)
sprintf(buf, "./inconsistency-check -t %i", secs);
ret = system(buf);
- if (ret)
- return ret;
+ if (WIFEXITED(ret) && WEXITSTATUS(ret))
+ return WEXITSTATUS(ret);
ret = system("./nanosleep");
- return ret;
+ return WIFEXITED(ret) ? WEXITSTATUS(ret) : 0;
}