aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorPing-Ke Shih <pkshih@realtek.com>2025-02-17 14:43:06 +0800
committerPing-Ke Shih <pkshih@realtek.com>2025-02-21 09:50:56 +0800
commit56e1acaa0f80620b8e2c3410db35b4b975782b0a (patch)
tree2f99e45522c27989791a81e8f85ce3fca4ea6970
parentwifi: rtw89: fw: get sb_sel_ver via get_unaligned_le32() (diff)
downloadwireguard-linux-56e1acaa0f80620b8e2c3410db35b4b975782b0a.tar.xz
wireguard-linux-56e1acaa0f80620b8e2c3410db35b4b975782b0a.zip
wifi: rtw89: fw: propagate error code from rtw89_h2c_tx()
The error code should be propagated to callers during downloading firmware header and body. Remove unnecessary assignment of -1. Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Link: https://patch.msgid.link/20250217064308.43559-4-pkshih@realtek.com
-rw-r--r--drivers/net/wireless/realtek/rtw89/fw.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 0a129476171a..e05034fbb898 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -1510,7 +1510,6 @@ static int __rtw89_fw_download_hdr(struct rtw89_dev *rtwdev,
ret = rtw89_h2c_tx(rtwdev, skb, false);
if (ret) {
rtw89_err(rtwdev, "failed to send h2c\n");
- ret = -1;
goto fail;
}
@@ -1597,7 +1596,6 @@ static int __rtw89_fw_download_main(struct rtw89_dev *rtwdev,
ret = rtw89_h2c_tx(rtwdev, skb, true);
if (ret) {
rtw89_err(rtwdev, "failed to send h2c\n");
- ret = -1;
goto fail;
}