diff options
| author |   Jérôme Pouiller <jerome.pouiller@silabs.com> | 2022-02-16 10:31:11 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-17 15:58:48 +0100 |
| commit | 5f86ecba8e8ed4d8e6896b8940b5796a86200408 (patch) | |
| tree | 6c10d7594df4e6b32faa4217abdd010e4b6cd051 | |
| parent | staging: r8188eu: rename CCKSwingTable_Ch1_Ch13 (diff) | |
| download | wireguard-linux-5f86ecba8e8ed4d8e6896b8940b5796a86200408.tar.xz wireguard-linux-5f86ecba8e8ed4d8e6896b8940b5796a86200408.zip | |
staging: wfx: WF200 has no official SDIO IDs
Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200
are official SDIO IDs. However, it is not the case, the values used by
WF200 are not official (BTW, the driver rely on the DT rather than on
the SDIO IDs to probe the device).
To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use
raw values.
Reviewed-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20220216093112.92469-2-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/wfx/bus_sdio.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c index bc3df85a05b6..312d2d391a24 100644 --- a/drivers/staging/wfx/bus_sdio.c +++ b/drivers/staging/wfx/bus_sdio.c @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func) sdio_release_host(func); } -#define SDIO_VENDOR_ID_SILABS 0x0000 -#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 static const struct sdio_device_id wfx_sdio_ids[] = { - { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, + /* WF200 does not have official VID/PID */ + { SDIO_DEVICE(0x0000, 0x1000) }, { }, }; MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); |