diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-12-08 21:37:35 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-12-12 09:53:10 +0000 |
| commit | 5fe02e046e6422c4adfdbc50206ec7186077da24 (patch) | |
| tree | 3804c99375eb7ca1163725841b56997580f49119 | |
| parent | net: apple: mace: don't call dev_kfree_skb() under spin_lock_irqsave() (diff) | |
| download | wireguard-linux-5fe02e046e6422c4adfdbc50206ec7186077da24.tar.xz wireguard-linux-5fe02e046e6422c4adfdbc50206ec7186077da24.zip | |
net: apple: bmac: don't call dev_kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.
It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.
In this case, dev_kfree_skb() is called in bmac_tx_timeout() to drop
the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/apple/bmac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index 334de0d93c89..9e653e2925f7 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c @@ -1510,7 +1510,7 @@ static void bmac_tx_timeout(struct timer_list *t) i = bp->tx_empty; ++dev->stats.tx_errors; if (i != bp->tx_fill) { - dev_kfree_skb(bp->tx_bufs[i]); + dev_kfree_skb_irq(bp->tx_bufs[i]); bp->tx_bufs[i] = NULL; if (++i >= N_TX_RING) i = 0; bp->tx_empty = i; |