aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorLuca Coelho <luciano.coelho@intel.com>2020-06-26 12:49:40 +0300
committerJohannes Berg <johannes.berg@intel.com>2020-06-26 11:52:57 +0200
commit60a0121f8fa64b0f4297aa6fef8207500483a874 (patch)
tree235b9c6431f193b354d89c5a3b78ec2d677e5000
parentnl80211: don't return err unconditionally in nl80211_start_ap() (diff)
downloadwireguard-linux-60a0121f8fa64b0f4297aa6fef8207500483a874.tar.xz
wireguard-linux-60a0121f8fa64b0f4297aa6fef8207500483a874.zip
nl80211: fix memory leak when parsing NL80211_ATTR_HE_BSS_COLOR
If there is an error when parsing the NL80211_ATTR_HE_BSS_COLOR attribute, we return immediately without freeing param.acl. Fit it by using goto out instead of returning immediately. Fixes: 5c5e52d1bb96 ("nl80211: add handling for BSS color") Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Link: https://lore.kernel.org/r/iwlwifi.20200626124931.7ad2a3eb894f.I60905fb70bd20389a3b170db515a07275e31845e@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/wireless/nl80211.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index f31698fd4a7e..0e07fb8585fb 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5025,7 +5025,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
info->attrs[NL80211_ATTR_HE_BSS_COLOR],
&params.he_bss_color);
if (err)
- return err;
+ goto out;
}
nl80211_calculate_ap_params(&params);