diff options
| author |   Thomas Fourier <fourier.thomas@gmail.com> | 2025-06-10 16:29:11 +0200 |
|---|---|---|
| committer |   Madhavan Srinivasan <maddy@linux.ibm.com> | 2025-07-09 09:15:10 +0530 |
| commit | 760b9b4f6de9a33ca56a05f950cabe82138d25bd (patch) | |
| tree | ed6cb26bed4582e67e5c68dc53015b491ae1ad16 | |
| parent | powerpc: floppy: Add missing checks after DMA map (diff) | |
| download | wireguard-linux-760b9b4f6de9a33ca56a05f950cabe82138d25bd.tar.xz wireguard-linux-760b9b4f6de9a33ca56a05f950cabe82138d25bd.zip | |
(powerpc/512) Fix possible `dma_unmap_single()` on uninitialized pointer
If the device configuration fails (if `dma_dev->device_config()`),
`sg_dma_address(&sg)` is not initialized and the jump to `err_dma_prep`
leads to calling `dma_unmap_single()` on `sg_dma_address(&sg)`.
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250610142918.169540-2-fourier.thomas@gmail.com
| -rw-r--r-- | arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c index 9668b052cd4b..f251e0f68262 100644 --- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c +++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c @@ -240,10 +240,8 @@ static int mpc512x_lpbfifo_kick(void) dma_conf.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; /* Make DMA channel work with LPB FIFO data register */ - if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) { - ret = -EINVAL; - goto err_dma_prep; - } + if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) + return -EINVAL; sg_init_table(&sg, 1); |