diff options
| author |   Sebastian Reichel <sebastian.reichel@collabora.com> | 2025-07-07 01:26:58 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2025-07-12 20:45:17 +0200 |
| commit | 7b41a2341fa62babda5d5c7a32c632e9eba2ee11 (patch) | |
| tree | 52f957742f60e068b2921c3cfa19dc49c96e57c2 | |
| parent | power: supply: twl4030_charger: Remove redundant pm_runtime_mark_last_busy() calls (diff) | |
| download | wireguard-linux-7b41a2341fa62babda5d5c7a32c632e9eba2ee11.tar.xz wireguard-linux-7b41a2341fa62babda5d5c7a32c632e9eba2ee11.zip | |
power: supply: core: fix static checker warning
static checker complains, that the block already breaks if IS_ERR(np)
and thus the extra !IS_ERR(np) check in the while condition is
superfluous. Avoid the extra check by using while(true) instead. This
should not change the runtime behavior at all and I expect the binary
to be more or less the same for an optimizing compiler.
Fixes: f368f87b22da ("power: supply: core: convert to fwnnode")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-pm/285c9c39-482c-480c-8b0b-07111e39fdfe@sabinyo.mountain/
Reviewed-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20250707-fix-psy-static-checker-warning-v1-1-42d555c2b68a@collabora.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
| -rw-r--r-- | drivers/power/supply/power_supply_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index aedb20c1d276..7c3913155dc0 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c @@ -212,7 +212,7 @@ static int __power_supply_populate_supplied_from(struct power_supply *epsy, break; } fwnode_handle_put(np); - } while (!IS_ERR(np)); + } while (true); return 0; } |