diff options
| author |   Daniel Golle <daniel@makrotopia.org> | 2023-05-09 03:20:06 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2023-05-10 09:23:53 +0100 |
| commit | 7c83e28f10830aa5105c25eaabe890e3adac36aa (patch) | |
| tree | 0c3674baae71025515eed358e484f99da984b489 | |
| parent | net: phy: bcm7xx: Correct read from expansion register (diff) | |
| download | wireguard-linux-7c83e28f10830aa5105c25eaabe890e3adac36aa.tar.xz wireguard-linux-7c83e28f10830aa5105c25eaabe890e3adac36aa.zip | |
net: ethernet: mtk_eth_soc: fix NULL pointer dereference
Check for NULL pointer to avoid kernel crashing in case of missing WO
firmware in case only a single WEDv2 device has been initialized, e.g. on
MT7981 which can connect just one wireless frontend.
Fixes: 86ce0d09e424 ("net: ethernet: mtk_eth_soc: use WO firmware for MT7981")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_wed.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 4c205afbd230..985cff910f30 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -654,7 +654,7 @@ __mtk_wed_detach(struct mtk_wed_device *dev) BIT(hw->index), BIT(hw->index)); } - if (!hw_list[!hw->index]->wed_dev && + if ((!hw_list[!hw->index] || !hw_list[!hw->index]->wed_dev) && hw->eth->dma_dev != hw->eth->dev) mtk_eth_set_dma_device(hw->eth, hw->eth->dev); |