aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2025-03-06 12:48:34 +0300
committerMark Brown <broonie@kernel.org>2025-03-06 13:27:16 +0000
commit7dfc9bdde9fa20cf1ac5cbea97b0446622ca74c7 (patch)
tree4684a52127df75ec46ede10dc5e3852cc135a357
parentAdd STM32MP25 SPI NOR support (diff)
downloadwireguard-linux-7dfc9bdde9fa20cf1ac5cbea97b0446622ca74c7.tar.xz
wireguard-linux-7dfc9bdde9fa20cf1ac5cbea97b0446622ca74c7.zip
spi: stm32-ospi: Fix an IS_ERR() vs NULL bug in stm32_ospi_get_resources()
The devm_ioremap() function returns NULL on error, it doesn't return error pointers. Fix the check to match. Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Link: https://patch.msgid.link/bc4c9123-df43-4616-962f-765801d30b4c@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-stm32-ospi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c
index 8eadcb64f34a..a544d7897edf 100644
--- a/drivers/spi/spi-stm32-ospi.c
+++ b/drivers/spi/spi-stm32-ospi.c
@@ -835,10 +835,10 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
if (rmem) {
ospi->mm_size = rmem->size;
ospi->mm_base = devm_ioremap(dev, rmem->base, rmem->size);
- if (IS_ERR(ospi->mm_base)) {
+ if (!ospi->mm_base) {
dev_err(dev, "unable to map memory region: %pa+%pa\n",
&rmem->base, &rmem->size);
- ret = PTR_ERR(ospi->mm_base);
+ ret = -ENOMEM;
goto err_dma;
}